Land P1 review epic, dogfood ast rules, run CI on every push#1
Merged
Conversation
P1 epic from the principal-engineer review (TASK-1.1 through 1.4): - ship `bully` console entrypoint (`bully validate / lint / doctor / show-resolved-config`); hook.sh continues to call pipeline.py by absolute path so the hook env doesn't depend on $PATH - skills + docs no longer hardcode $HOME/.bully/pipeline/pipeline.py; primary path is `bully` with documented plugin/manual fallbacks - top-level `skip:` in .bully.yml + ~/.bully-ignore merge with built-in SKIP_PATTERNS so multi-language monorepos don't have to patch source - --explain flag surfaces per-rule verdict (fire/pass/skipped <reason>/ dispatched); run_pipeline gains include_skipped=True; hook-mode shape unchanged Trust-gate docs in SECURITY.md; ast-engine + trust-gate tests land for the prior P0 work. Dogfood ourselves on the new tooling: - two engine: ast rules in .bully.yml (prefer-perf-counter, no-shell-true-subprocess) scoped to pipeline source; the legitimate shell=True in execute_script_rule carries an inline bully-disable - scripts/dogfood.sh prefers `bully lint` when on PATH and runs `bully validate` as a sanity preamble - CI installs ast-grep-cli so ast rules actually fire instead of silently skipping; runs on every push (not just main) Tests: 226 -> 243. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CI surfaced an unused `cfg` binding in test_hook_mode_output_does_not_include_semantic_skipped (the helper writes the file as a side effect; the variable wasn't read). Also pick up ruff format's reflow on pipeline.py and test_skip_config.py. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1 epic from the principal-engineer review (TASK-1.1 through 1.4):
bullyconsole entrypoint (bully validate / lint / doctor / show-resolved-config); hook.sh continues to call pipeline.py by absolute path so the hook env doesn't depend on $PATHbullywith documented plugin/manual fallbacksskip:in .bully.yml + ~/.bully-ignore merge with built-in SKIP_PATTERNS so multi-language monorepos don't have to patch sourceTrust-gate docs in SECURITY.md; ast-engine + trust-gate tests land for the prior P0 work.
Dogfood ourselves on the new tooling:
bully lintwhen on PATH and runsbully validateas a sanity preambleTests: 226 -> 243.